Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-cytoscapejs 2 #183

Closed
wants to merge 3 commits into from
Closed

Conversation

akx
Copy link

@akx akx commented Sep 6, 2022

About

I checked that the Webpack builds pass, hoping that CI here would do the rest.

Cc

Description of changes

See above.

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly.
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 馃拑'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

See plotly/react-cytoscapejs#99 for the discussion around react-cytoscapejs 2.

* remove the Python 2.x biopython dependency; the package isn't expected to run on Python 2
* bump Dash dependency to any 2.x version (2.0 was released in Sep 2021) to match setup.py pinning
@alexcjohnson
Copy link
Collaborator

Thanks @akx. Looks like there are some build issues on CI... if you're motivated to dig in you're more than welcome, I've updated the permissions so it should work fine from your fork now, but I'm also happy to let this one wait a bit until someone from Plotly gets a chance to poke around here.

@akx
Copy link
Author

akx commented Sep 8, 2022

@alexcjohnson Well, it worked for exactly one build... 馃榿

I think #179 is related here; since pip install has been set to --quiet I can't verify which version of dash is exactly being used, but it's obviously not one with plotly/dash#1995 in, since the one build failed with

  File "/home/circleci/project/venv/lib/python3.7/site-packages/dash/dash.py", line 22, in <module>
    from werkzeug.debug.tbtools import get_current_traceback
ImportError: cannot import name 'get_current_traceback' from 'werkzeug.debug.tbtools' (/home/circleci/project/venv/lib/python3.7/site-packages/werkzeug/debug/tbtools.py)

@alexcjohnson
Copy link
Collaborator

Yeah weird. Feel free to remove --quiet - and thanks for the nudge on #179

@alexcjohnson
Copy link
Collaborator

Done in #193 - thanks @akx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants