Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's records not rows #382

Merged
merged 3 commits into from Apr 26, 2019
Merged

it's records not rows #382

merged 3 commits into from Apr 26, 2019

Conversation

chriddyp
Copy link
Member

rows “happens” to work because pandas only looks at the first letter
(“r”).

🙈

rows “happens” to work because pandas only looks at the first letter
(“r”).
- docs here:
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFr
ame.to_dict.html
- community thread here:
https://community.plot.ly/t/data-table-quick-start-example-not-showing-d
ata/18734/2
@chriddyp
Copy link
Member Author

Hm, that's odd. The records aren't showing up. In the community forum, this was apparently related to a bug in pandas, so perhaps we need to pin things down more in this repo.
image

@eiriklid
Copy link

There is a bug in pandas 0.24.0, that will be fixed in the next iteration. Ref: pandas-dev/pandas#24940

The example is working with pandas 0.23.4

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I locked pandas to 0.24.2, working again. Will merge once tests pass.

@alexcjohnson alexcjohnson merged commit feb14bb into master Apr 26, 2019
@alexcjohnson alexcjohnson deleted the records-not-rows branch April 26, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants