Rename reloadHash store to reloadRequests, add intervalId as state.

plotly · Sep 13, 2018 · 9c9c797 · 9c9c797
1 parent 1a8fd9c
commit 9c9c797
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/src/components/core/Reloader.react.js b/src/components/core/Reloader.react.js
@@ -11,27 +11,27 @@ class Reloader extends React.Component {
             this.state = {
                 hash: null,
                 interval,
-                disabled: false
+                disabled: false,
+                intervalId: null
             }
         } else {
             this.state = {
                 disabled: true
             }
         }
-        this._intervalId = null;
     }
 
     componentDidUpdate() {
-        const {reloadHash, dispatch} = this.props;
-        if (reloadHash.status === 200) {
+        const {reloadRequest, dispatch} = this.props;
+        if (reloadRequest.status === 200) {
             if (this.state.hash === null) {
-                this.setState({hash: reloadHash.content.reloadHash});
+                this.setState({hash: reloadRequest.content.reloadHash});
                 return;
             }
-            if (reloadHash.content.reloadHash !== this.state.hash) {
+            if (reloadRequest.content.reloadHash !== this.state.hash) {
                 // eslint-disable-next-line no-undef
                 window.clearInterval(this._intervalId);
-                if (reloadHash.content.hard) {
+                if (reloadRequest.content.hard) {
                     // Assets file have changed, need to reload them.
                     // eslint-disable-next-line no-undef
                     window.top.location.reload();
@@ -46,17 +46,18 @@ class Reloader extends React.Component {
     componentDidMount() {
         const { dispatch } = this.props;
         const { disabled, interval } = this.state;
-        if (!disabled && !this._intervalId) {
-            this._intervalId = setInterval(() => {
+        if (!disabled && !this.state.intervalId) {
+            const intervalId = setInterval(() => {
                 dispatch(getReloadHash());
             }, interval);
+            this.setState({intervalId})
         }
     }
 
     componentWillUnmount() {
-        if (!this.state.disabled) {
+        if (!this.state.disabled && this.state.intervalId) {
             // eslint-disable-next-line no-undef
-            window.clearInterval(this._intervalId);
+            window.clearInterval(this.state.intervalId);
         }
     }
 
@@ -70,15 +71,15 @@ Reloader.defaultProps = {};
 Reloader.propTypes = {
     id: PropTypes.string,
     config: PropTypes.object,
-    reloadHash: PropTypes.object,
+    reloadRequest: PropTypes.object,
     dispatch: PropTypes.func,
     interval: PropTypes.number
 };
 
 export default connect(
     state => ({
         config: state.config,
-        reloadHash: state.reloadHash
+        reloadRequest: state.reloadRequest
     }),
     dispatch => ({dispatch})
 )(Reloader);

diff --git a/src/reducers/reducer.js b/src/reducers/reducer.js
@@ -20,7 +20,7 @@ const reducer = combineReducers({
     dependenciesRequest: API.dependenciesRequest,
     layoutRequest: API.layoutRequest,
     loginRequest: API.loginRequest,
-    reloadHash: API.reloadRequest,
+    reloadRequest: API.reloadRequest,
     history
 });