Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

missing a fetch polyfill? #87

Closed
chriddyp opened this issue Oct 11, 2018 · 14 comments · Fixed by #86
Closed

missing a fetch polyfill? #87

chriddyp opened this issue Oct 11, 2018 · 14 comments · Fixed by #86
Assignees

Comments

@chriddyp
Copy link
Member

I've tested this in IE11 myself, so I'm surprised by this bug report, but perhaps we're missing a fetch polyfill: https://community.plot.ly/t/on-ie11-getting-error-script5009-fetch-is-undefined/14445

@chriddyp
Copy link
Member Author

@valentijnnieman - could you look into this one?

@valentijnnieman valentijnnieman self-assigned this Oct 11, 2018
@valentijnnieman
Copy link
Contributor

@chriddyp Can you invite me to Browserstack?

@T4rk1n
Copy link
Contributor

T4rk1n commented Oct 11, 2018

I think we might have lost the whatwg-fetch polyfill with the webpack config changes, it needs to be added to the entry in webpack.config.js

@valentijnnieman
Copy link
Contributor

I added it back in in #86

@chriddyp
Copy link
Member Author

OK cool, let's get #86 merged and released ASAP then

@mbkupfer
Copy link

mbkupfer commented Oct 11, 2018

Hi, not sure the status of this issue, but I uploaded to dash-render 0.14.2 and now I'm getting a new error in IE:

[object Error]{@@hasInstance: undefined, @@isConcatSpreadable: undefined, @@iterator: undefined, @@match: undefined, @@replace: undefined, @@search: undefined, @@species: undefined, @@split: undefined, @@toPrimitive: undefined, @@toStringTag: undefined, @@unscopables: undefined, description: "Object does...", message: "Object does...", name: "TypeError", number: -2146827850, stack: "TypeError: ..."}

Anyone else getting this error?

@mbkupfer
Copy link

Here is the stacktrace as well. Hopefully this will be helpful in addition to the top error message.

"TypeError: Object doesn't support property or method 'find'
   at b (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:1:20134)
   at Anonymous function (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:1:19927)
   at Anonymous function (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:18:52485)
   at s.dispatch (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:12:8197)
   at Anonymous function (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:1:16964)
   at Anonymous function (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:1:16805)
   at Anonymous function (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:1:16587)
   at Anonymous function (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:18:52485)
   at value (https://unpkg.com/dash-renderer@0.14.2/dash_renderer/dash_renderer.min.js:27:7441)
   at value (https:"

@chriddyp
Copy link
Member Author

chriddyp commented Oct 11, 2018

Yikes, it looks like we're missing a few polyfills here. @valentijnnieman et al, we should just include the babel polyfill: https://babeljs.io/docs/en/babel-polyfill I think

@chriddyp
Copy link
Member Author

I'll look into adding this now so that we can get out the fix asap

@chriddyp
Copy link
Member Author

polyfill PR #89

@chriddyp
Copy link
Member Author

@mbkupfer - New release at pip install dash-renderer==0.14.3. Could you try it out?

@mbkupfer
Copy link

@chriddyp - Just tested it and everything looks great! Hooray for IE compatibility!!! 🙌

@chriddyp
Copy link
Member Author

🙌 🙌 🙌

@adamkgoldfarb
Copy link

+1 for "works for me"! IE is looking great. Thanks for the quick response!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants