This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Add any react bundled version from dash_renderer to MANIFEST.in #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact version from a dash application. Adds test for scripts versions served by Dash. Updates CHANGELOG to reflect new usage
…n DocumentTitle and Loading
# Conflicts: # CHANGELOG.md # dash_renderer/version.py # package-lock.json # package.json
chriddyp
reviewed
Mar 29, 2018
| include dash_renderer/react-dom@15.4.2.min.js | ||
| include dash_renderer/react@15.4.2.min.js | ||
| include dash_renderer/react-dom@*.min.js | ||
| include dash_renderer/react@*.min.js |
There was a problem hiding this comment.
Nice, didn't know we could use *
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates MANIFEST.in to
to correctly publish to PyPI.
Closes #49
@chriddyp The PR merged yesterday missed updating the MANIFEST.in 🤦♂️ Feel free to accept either this PR, which has more changes in the CHANGELOG and updates the version to 0.12.1, or to accept #48 from @utyf and just overwrite the existing 0.12.0 on PyPI.