This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix undo button bug #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This was going to be a part of the Dev Tools PR since this bug was affecting functionality there, but I think we can release this now since some community members are also experiencing this bug and we have a bit of time before Dev Tools will be released (e.g. plotly/dash#234 (comment)) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
Previously,
state.history.presentwas only updated on the first Dash callback, meaning actions which are applied to a different component than the previous action would not be recorded. To fix, we just setstate.history.presenton every callback.