Dash live model training #211

christopherjeon · 2019-07-05T18:46:30Z

Issue for app: #33

App pull request

This is a new app
I am improving an existing app (redesigns/code "makeovers")

About

Playground deployment URL (new version): https://dash-playground.plotly.host/dash-live-model-training/

Workflow

I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
I have removed all Google Analytics code from the app's
assets/ folder.

The pre-review review

I have addressed all of the following questions:

Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

…bile layout

…nal issues on smaller screens

apps/dash-live-model-training/requirements.txt

celinehuang · 2019-07-12T14:21:30Z

I think this is in-between mobile and desktop version, looks kinda odd so either keep it mobile or desktop

celinehuang · 2019-07-12T14:38:58Z

Maybe reduce the margin on the right side and make the fonts bigger
Make sure the mobile layout works for all mobile version, this is the IPhone 5/SE

celinehuang

Is there a reason why you removed the flex boxes? Because the mockup has the boxes. Otherwise everything looks good :)

celinehuang · 2019-07-12T14:48:35Z

apps/dash-live-model-training/assets/base.css

+.banner {
+  height: 75px;
+  background-color: #191e27;
+  /* border-radius: 5px 5px 2px 2px; */


remove unnecessary comments!

apps/dash-live-model-training/assets/base.css

celinehuang · 2019-07-12T14:49:47Z

apps/dash-live-model-training/assets/live-model-training.css

+    width: 100%;
+}
+
+._dash-undo-redo {


this is not needed after the update to dash==1.0.0

are you referring to the entire file or the _dash-undo-redo part?

Just the _dash-undo-redo part! That button is hidden by default.

celinehuang · 2019-07-12T14:51:46Z

apps/dash-live-model-training/README.md

+
+Dash abstracts away all of the technologies and protocols required to build an interactive web-based application and is a simple and effective way to bind a user interface around your Python code. To learn more check out our [documentation](https://plot.ly/dash).
+
+Try out the [demo app here](https://dash-live-model-training.plot.ly/).


I think this is a dead link!

apps/dash-live-model-training/app.py

ronniebugia · 2019-07-08T17:49:34Z

apps/dash-live-model-training/assets/font.css

+  font-weight: 400;
+  src: local('Roboto'), local('Roboto-Regular'), url(https://fonts.gstatic.com/s/roboto/v19/KFOmCnqEu92Fr1Mu4mxKKTU1Kg.woff2) format('woff2');
+  unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
+}


You can just include all these fonts in a css import in your base.css using this line @import url('https://fonts.googleapis.com/css?family=Open+Sans|Roboto&display=swap');

apps/dash-live-model-training/requirements.txt

apps/dash-live-model-training/runtime.txt

ronniebugia · 2019-07-08T17:54:39Z

apps/dash-live-model-training/app.py

+                                                    },
+                                                ],
+                                                placeholder="Select a demo dataset",
+                                                searchable=False,


I recommend adding a default value for dropdown-demo-dataset and dropdown-simulation-model. Also maybe add some headers for each dropdown to explain what it does.

^ 👍 to this comment!

I set the default values to MNIST and Simple Conv Net now

apps/dash-live-model-training/app.py

shammamah-zz · 2019-07-18T14:27:02Z

apps/dash-live-model-training/README.md

+
+Try out the [demo app here](https://dash-gallery.plotly.host/dash-live-model-training/).
+
+![animated1](images/animated1.gif)


Make sure this is updated!

shammamah-zz · 2019-07-18T14:27:54Z

apps/dash-live-model-training/demo.md

@@ -0,0 +1,38 @@
+## Getting Started with the Demo


Suggested change

## Getting Started with the Demo

## Getting Started With the Demo

shammamah-zz

Awesome work! 💃

celinehuang

💃

shammamah-zz

💃

celinehuang

💃 looks good!

celinehuang and others added 12 commits May 21, 2019 12:23

Initial Commit

6ab1fc7

changed basic layout, updated README

fec6e66

changed line chart colors and added containers to separate graphs

ec907ed

deleted unnescessary files and old links in the markdown files

1014f47

added multi-output call back for learn more button

9038c93

removed unnecessary comments

7caa98a

added all csv files to the data folder and cleaned up code for the mo…

6fd5f99

…bile layout

Fixed title bar, configured dropdown, centered radio items

be304bf

Redesigned plot display mode and current accuracy

e0634e1

Fixed interval control div

11473e5

Fixed run-log-storage and storage-simulated-run IDs

155c93e

run black tests

fc5b510

christopherjeon requested review from celinehuang, ronniebugia and shammamah-zz July 8, 2019 14:04

christopherjeon added 4 commits July 11, 2019 10:26

apply two column format for mobile layout

b865f51

correct Current Accuracy and Current Loss layouts + fix minor positio…

84895b2

…nal issues on smaller screens

get rid of stylesheet for iPad, will modify later

d8f6d25

run black tests

34524ef

shammamah-zz reviewed Jul 11, 2019

View reviewed changes

apps/dash-live-model-training/requirements.txt Outdated Show resolved Hide resolved

celinehuang reviewed Jul 12, 2019

View reviewed changes

ronniebugia reviewed Jul 12, 2019

View reviewed changes

christopherjeon added 4 commits July 12, 2019 16:08

implement correct layout for all mobile viewports

2f12071

run Black tests again

ccb4eec

correct label beside radio buttoms + reposition steps

5ef771f

update README dead link

7fe92f2

christopherjeon requested review from celinehuang and shammamah-zz July 17, 2019 18:54

christopherjeon and others added 2 commits July 17, 2019 15:46

fix positioning of radio buttons on second page

9db3d43

Merge branch 'master' into dash-live-model-training

ee5aa44

shammamah-zz reviewed Jul 18, 2019

View reviewed changes

christopherjeon added 3 commits July 18, 2019 14:42

fix issues brought up from Ronnie's/Sham's code review

be62d10

complete merge

e5a4f33

run black tests

2d6e55a

christopherjeon requested review from shammamah-zz and ronniebugia July 18, 2019 19:33

shammamah-zz previously approved these changes Jul 19, 2019

View reviewed changes

christopherjeon requested review from celinehuang and removed request for ronniebugia and celinehuang July 19, 2019 18:11

celinehuang previously approved these changes Jul 22, 2019

View reviewed changes

celinehuang requested a review from shammamah-zz July 22, 2019 17:55

change color of step count

ec44413

christopherjeon dismissed stale reviews from celinehuang and shammamah-zz via ec44413 July 22, 2019 18:21

shammamah-zz approved these changes Jul 23, 2019

View reviewed changes

shammamah-zz requested review from celinehuang July 23, 2019 19:09

celinehuang approved these changes Jul 23, 2019

View reviewed changes

Merge branch 'master' into dash-live-model-training

81a6e41

christopherjeon merged commit 344cd2b into master Jul 24, 2019

christopherjeon mentioned this pull request Jul 29, 2019

Dash live model training (address issue #249) #250

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dash live model training #211

Dash live model training #211

christopherjeon commented Jul 5, 2019

celinehuang commented Jul 12, 2019

celinehuang commented Jul 12, 2019

celinehuang left a comment •

edited

celinehuang Jul 12, 2019

celinehuang Jul 12, 2019

christopherjeon Jul 15, 2019

shammamah-zz Jul 18, 2019

celinehuang Jul 12, 2019

ronniebugia Jul 8, 2019

ronniebugia Jul 8, 2019

shammamah-zz Jul 18, 2019

christopherjeon Jul 18, 2019

shammamah-zz Jul 18, 2019

christopherjeon Jul 18, 2019

shammamah-zz Jul 18, 2019

shammamah-zz left a comment

celinehuang left a comment

shammamah-zz left a comment

celinehuang left a comment


		Dash abstracts away all of the technologies and protocols required to build an interactive web-based application and is a simple and effective way to bind a user interface around your Python code. To learn more check out our [documentation](https://plot.ly/dash).

		Try out the [demo app here](https://dash-live-model-training.plot.ly/).


		Try out the [demo app here](https://dash-gallery.plotly.host/dash-live-model-training/).

		![animated1](images/animated1.gif)

	## Getting Started with the Demo
	## Getting Started With the Demo

Dash live model training #211

Dash live model training #211

Conversation

christopherjeon commented Jul 5, 2019

App pull request

About

Workflow

The pre-review review

celinehuang commented Jul 12, 2019

celinehuang commented Jul 12, 2019

celinehuang left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shammamah-zz left a comment

Choose a reason for hiding this comment

celinehuang left a comment

Choose a reason for hiding this comment

shammamah-zz left a comment

Choose a reason for hiding this comment

celinehuang left a comment

Choose a reason for hiding this comment

celinehuang left a comment •

edited