-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automation to automatically release zipped apps #560
Conversation
- Automatically bump version - Upload zipped apps - Release app
What if we only ever had one release available? ie after uploading the new release we delete the previous one(s)? This feels like a bit of a misuse of the release mechanism, but it would make https://github.com/plotly/dash-sample-apps/releases much cleaner, and folks would likely just go there and download the zip they want. |
Yeah it shouldn't be too hard. (edit: I just tried it here and it worked) I guess it does make it cleaner, although Github seems to automatically hide the assets of older releases to make it easier to navigate. Moreover replacing the version number with "latest" automatically resolves it. Though I agree it looks a lot cleaner when you look at the tags. I think one potential advantage will be to more easily access older versions of a certain app, especially if we start versioning based on dash's major version (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 OK, let's keep it as you have, and we can revisit if the many releases become overwhelming. It feels a little confusing to me since most releases will only update one or two apps, but I agree that it could sometimes be useful to go back in time to an older version of an app.
Just a documentation comment, but this looks great!
Thanks, I updated the readme with your suggestions; will merge now.
I think it's a good idea. In fact I feel a lot of the readme might be confusing for the community; it feels to me it was written for internal use. Would be nice to refactor the entire readme and move some parts to contributing.md |
Add automation to automatically release zipped apps Former-commit-id: ce31166
Closes #559
Whenever a commit is pushed to master:
Issue for app: #[issue number here]
App pull request
About
Workflow
elements necessary for successful deployment are in place.
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
the GitHub repository for the source code in the portal description.
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.=
assets/
folder.The pre-review review
I have addressed all of the following questions:
any dead and/or irrelevant code.)
readable and, where it isn't, it has been commented appropriately.)]
lessen the volume of code that needs to be maintained.)