Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

can we make the id prop optional? #139

Closed
chriddyp opened this issue Oct 17, 2018 · 3 comments · Fixed by #155
Closed

can we make the id prop optional? #139

chriddyp opened this issue Oct 17, 2018 · 3 comments · Fixed by #155
Assignees

Comments

@chriddyp
Copy link
Member

No description provided.

@Marc-Andre-Rivet
Copy link
Contributor

Yes. But we will need to generate one at random for the internal stylesheet.

@Marc-Andre-Rivet
Copy link
Contributor

Expected:

  • optional id + auto generation (to respect HTML5/CSS specs, prefix it with something like 'id' so it starts with letters)
  • styling still works and is isolated after making id optional
  • update props in Table.js and table/props.ts
  • ControlledTable still expects 'id' to be defined -- non-controlled TS table is responsible for guaranteeing a value
  • at least one visual test that demonstrates that visual styles are applied to table w/o id

@Marc-Andre-Rivet
Copy link
Contributor

@valentijnnieman For the prefix, etc. this issue relates to #136

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants