Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

quotes are required for filtering text entries with spaces in it #598

Closed
chriddyp opened this issue Sep 20, 2019 · 2 comments
Closed

quotes are required for filtering text entries with spaces in it #598

chriddyp opened this issue Sep 20, 2019 · 2 comments
Assignees
Labels
dash-type-bug Something isn't working as intended dash-type-enhancement New feature or request size: 1
Milestone

Comments

@chriddyp
Copy link
Member

Currently, you need to supply quotes around text when filtering. I think our default behavior should allow filtering strings without this as using quotes isn't discoverable.

filtering with spaces

@chriddyp
Copy link
Member Author

chriddyp commented Sep 20, 2019

Relatedly, I don't understand why PRODUCT 3 returns all of the results?

@chriddyp chriddyp added the dash-type-bug Something isn't working as intended label Sep 20, 2019
@Marc-Andre-Rivet
Copy link
Contributor

Marc-Andre-Rivet commented Sep 20, 2019

The quotes being required is not a bug but working as intended.

Expected in 4.3.0

  • User enters PRODUCT 3
  • The filter parsing to fail resulting in a red highlight on that cell
  • No filter is applied

"PRODUCT 3" and PRODUCT\s3 would behave as desired, filtering for PRODUCT 3.

Should be possible to allow for a more permissive string selector for the single column case because the form of the filter is limited to few cases:

  • <unary>
  • <relational> <value|expression>
  • <value|expression>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended dash-type-enhancement New feature or request size: 1
Projects
None yet
Development

No branches or pull requests

2 participants