3.0 clean offsets #110

Marc-Andre-Rivet · 2018-09-25T17:39:04Z

No description provided.

- clean up props / build update

# Conflicts: # dash_table/bundle.js # dash_table/demo.js

…clean-offsets # Conflicts: # dash_table/bundle.js # dash_table/demo.js # src/dash-table/components/CellFactory.tsx # src/dash-table/components/ControlledTable/index.tsx # tests/e2e/cypress/integration/dash_test.ts # tests/e2e/cypress/integration/delete_row_test.ts

…clean-offsets # Conflicts: # tests/e2e/cypress/integration/dash_test.ts

- cleanup "hidden" conditional processing

# Conflicts: # CHANGELOG.md # dash_table/bundle.js # dash_table/demo.js # dash_table/package.json # package.json # src/dash-table/components/CellFactory.tsx # src/dash-table/components/ControlledTable/index.tsx # src/dash-table/components/HeaderFactory.tsx # src/dash-table/components/Table/index.tsx # src/dash-table/components/Table/props.ts # tests/e2e/cypress/integration/delete_row_test.ts

Marc-Andre-Rivet · 2018-09-25T17:39:22Z

dash_table/package.json

@@ -1,6 +1,6 @@
 {
  "name": "dash-table",
-  "version": "3.1.0rc1",
+  "version": "3.1.0rc2",


bump version

Marc-Andre-Rivet · 2018-09-25T17:39:39Z

demo/App.js

@@ -42,7 +42,7 @@ class App extends Component {
                    }
                ],
                table_style: [
-                    { selector: '.dash-spreadsheet.freeze-left', rule: 'width: 1000px; max-width: 1000px;' }
+                    { selector: '.dash-spreadsheet.dash-freeze-left', rule: 'width: 1000px; max-width: 1000px;' }


style -- add prefix for external/contract classes

Marc-Andre-Rivet · 2018-09-25T17:41:57Z

src/dash-table/Table.js

+            Logger.error(`Invalid combination of filtering / sorting / pagination`, filtering, sorting, pagination_mode);
+            return (<div>Invalid props combination</div>);
+        }
+
        return (<RealTable {...this.props} />);


Table.js is the Dash component wrapper, its role is to

bridge the dash and TS worlds

make sure the props are sane

Here we add the first sanity check: are the sorting/paging/filtering props compatible with each other?

If paging is done BE -> sort/filter must be off or in BE
Otherwise all combos are valid

Marc-Andre-Rivet · 2018-09-25T17:43:05Z

src/dash-table/components/Cell/index.tsx

        return (<td
            ref='td'
            tabIndex={-1}
            className={this.classes.join(' ')}
            style={this.style}
+            data-dash-column={property}


Instead of exposing the columns as column-{index} classes, expose as an attribute with value equal to column id -- this is more consistent with what the user gives us and less about implementation details

valentijnnieman

Looks good to me. Tiny suggestion on naming.

valentijnnieman · 2018-09-25T17:52:00Z

src/dash-table/Table.js

+            pagination_mode
+        } = this.props;
+
+        function isFe(value: any) {


Maybe a full description in the name, like isFrontEnd is better here?

valentijnnieman · 2018-09-25T17:52:19Z

src/dash-table/Table.js

+            return ['fe', true, false].indexOf(value) !== -1;
+        }
+
+        function isBe(value: any) {


Similarly here, isBackEnd could be slightly more readable.

@cldougl

* 3.1 props refactoring (#106) * refactor virtualization, virtualization settings, and derived props * refactor renaming paging / pagination props * refactor virtual, viewport and pagination into adapters * isolate derived props * build update * fix regression * improve typing * fix test regression * simplify pagination adapter / refactor * lint * clean up unused props * - change factory - clean up props / build update * fix lint * bump version * add dash level props for virtual_dataframe * refactor fp / derived props * derived props * refactor viewport and virtual controlled props * fix fp regression * fix fp regression * refactor controlled table / table fp * controlled table purecomponent * fix test (rebrake it!) * fix selection regression for be paging/sorting/filtering * improve re-renders & controlled props * fix test regressions * update inner-selection fixture * remove useless spy * - fix pr comment - fix for IE/Edge * clean up * 3.0 clean offsets (#110) * refactor virtualization, virtualization settings, and derived props * refactor renaming paging / pagination props * refactor virtual, viewport and pagination into adapters * isolate derived props * build update * fix regression * improve typing * fix test regression * simplify pagination adapter / refactor * lint * clean up unused props * - change factory - clean up props / build update * fix lint * bump version * add dash level props for virtual_dataframe * cleaup offsets * triad validation * - define external facing classes and attributes * fix regression, update build * fix test regression (invalid props) * update test name * refactor fp / derived props * derived props * refactor viewport and virtual controlled props * fix fp regression * fix fp regression * refactor controlled table / table fp * controlled table purecomponent * fix test (rebrake it!) * fix selection regression for be paging/sorting/filtering * improve re-renders & controlled props * fix test regressions * update inner-selection fixture * remove useless spy * - control columns into visible columns - cleanup "hidden" conditional processing * update changelog * clean up header factory * apply style on first controlled table render * typo/merge miss * derived visible columns * - visual tests for hidden columns * rename functions * - fix dropdown styling regression * lint * 3.1 props fixes (#112) * props fixes * update changelog * bump version * filter typing * Update derivedViewport_test.ts Add basic viewport test with |df| > page_size * ☝️ 3 new review / documentation / target apps see discussion in #108 * 🙈 forgot file * 📝 incorporate @cldougl suggestions 🙇 * 3.1 refactor tests (#113) * props fixes * update changelog * bump version * filter typing * - delete unused usage files - restructure tests folder * - separate cypress and visual tests into 2 ci jobs * - build before tests! * add browsers to the node image for visual-test * 💯 add percent examples * 📝 title/example clarification * reformat sizing test app for failing tests (#125) * Removed .only from dash_test.ts * Production build instead of dev 🙈 * Fix failing tests * 3.1 refactor cells rendering (#123) * WIP - memoize cell event handlers as derived values - isolate cell event handlers * wip - attempt to isolate cell logic from input logic for individual datum * wip - celan up cell wrapper - isolate input logic a bit more * further down the rabbit hole.. - separating operation cells from content * fix dropdown navigation regression * fix selected row regression * renaming / restructuring * rename/restructure * - clean up zipping - separate wrappers from styles * rework style/ast cache * clean up * clean up * build update * improve rendering perf * optimize wrappers generation * build config * - fix typing regression - fix rendering perf regression * - fix navigation regression * simplify slightly the derived props / ui * fix copy/paste regressions * clean up wrapper props * clean up * fix regression on conditional dropdowns * wip, fp the headers * fp content, wrappers, labels, indices from header factory * fix regressions * fp the table itself * fix typing and behavior for table fp * fix sorting icon regression * fix regression * regression * fix column name regression with only 1 header row * fix header actions regression * fix style application on mount * fix regression edit cell in n-th page * fix editing on non-first page (continued) * fix test * 3.1 issue118 width behavior (#130) * WIP - memoize cell event handlers as derived values - isolate cell event handlers * wip - attempt to isolate cell logic from input logic for individual datum * wip - celan up cell wrapper - isolate input logic a bit more * further down the rabbit hole.. - separating operation cells from content * fix dropdown navigation regression * fix selected row regression * renaming / restructuring * rename/restructure * - clean up zipping - separate wrappers from styles * rework style/ast cache * clean up * clean up * build update * improve rendering perf * optimize wrappers generation * build config * - fix typing regression - fix rendering perf regression * - fix navigation regression * simplify slightly the derived props / ui * fix copy/paste regressions * clean up wrapper props * clean up * fix regression on conditional dropdowns * wip, fp the headers * fp content, wrappers, labels, indices from header factory * fix regressions * fp the table itself * fix typing and behavior for table fp * fix sorting icon regression * fix regression * regression * fix column name regression with only 1 header row * fix header actions regression * add width percentage support + content_style * fix style application on mount * fix visual regression with empty df * only apply row style when necessary * fix tab test (no offset) * clean up header styling * use dash-* classes * support default column width (override input behavior) * fix regression edit cell in n-th page * fix editing on non-first page (continued) * fix test * fit to content behavior * fix regressions * fix lint * add column width visual tests * fix dropdown minimum size when using default width * sizing examples * black * fix navigation test regression * fix regressions in visual tests * default column width - fix dropdown width eval * default width columns - fix width when first content row is search filter * percy - add delay before screenshot (attempt to fix FF visual tests) * debugging selenium * fix black * debug selenium * debug selenium * fix black * debug selenium * debug selenium * debug selenium * undo all selenium modifications * default column width - filter inputs behave like cell inputs (do not affect width) * - fixed rows+columns height evaluated correctly * remove dead code * remove .only from tests * add data-dash-column to filter cells * styling examples (#117) * 🌈 styling examples examples that represent of the level of customization that we need in dash-table. The examples are implemented with HTML tables to demonstrate the intended behaviour. I’d like to see each of these examples implemented with the `dash_table` syntax. We’ll use these examples as our `dash-table` documentation * ❌ removing black and pylint this keeps tripping us up and I don’t think it’s worth the pain right now. * Backend examples (#119) * 🏭 backend computed data usage examples * 📊 tying it together w a graph * ❓ not sure what `displayed_pages` does? * Dropdown usage examples (#120) * ⬇️ dropdown usage examples * add conditional dropdown example

@cldougl

* 3.1 props refactoring (#106) * refactor virtualization, virtualization settings, and derived props * refactor renaming paging / pagination props * refactor virtual, viewport and pagination into adapters * isolate derived props * build update * fix regression * improve typing * fix test regression * simplify pagination adapter / refactor * lint * clean up unused props * - change factory - clean up props / build update * fix lint * bump version * add dash level props for virtual_dataframe * refactor fp / derived props * derived props * refactor viewport and virtual controlled props * fix fp regression * fix fp regression * refactor controlled table / table fp * controlled table purecomponent * fix test (rebrake it!) * fix selection regression for be paging/sorting/filtering * improve re-renders & controlled props * fix test regressions * update inner-selection fixture * remove useless spy * - fix pr comment - fix for IE/Edge * clean up * 3.0 clean offsets (#110) * refactor virtualization, virtualization settings, and derived props * refactor renaming paging / pagination props * refactor virtual, viewport and pagination into adapters * isolate derived props * build update * fix regression * improve typing * fix test regression * simplify pagination adapter / refactor * lint * clean up unused props * - change factory - clean up props / build update * fix lint * bump version * add dash level props for virtual_dataframe * cleaup offsets * triad validation * - define external facing classes and attributes * fix regression, update build * fix test regression (invalid props) * update test name * refactor fp / derived props * derived props * refactor viewport and virtual controlled props * fix fp regression * fix fp regression * refactor controlled table / table fp * controlled table purecomponent * fix test (rebrake it!) * fix selection regression for be paging/sorting/filtering * improve re-renders & controlled props * fix test regressions * update inner-selection fixture * remove useless spy * - control columns into visible columns - cleanup "hidden" conditional processing * update changelog * clean up header factory * apply style on first controlled table render * typo/merge miss * derived visible columns * - visual tests for hidden columns * rename functions * - fix dropdown styling regression * lint * 3.1 props fixes (#112) * props fixes * update changelog * bump version * filter typing * Update derivedViewport_test.ts Add basic viewport test with |df| > page_size * ☝️ 3 new review / documentation / target apps see discussion in #108 * 🙈 forgot file * 📝 incorporate @cldougl suggestions 🙇 * 3.1 refactor tests (#113) * props fixes * update changelog * bump version * filter typing * - delete unused usage files - restructure tests folder * - separate cypress and visual tests into 2 ci jobs * - build before tests! * add browsers to the node image for visual-test * 💯 add percent examples * 📝 title/example clarification * reformat sizing test app for failing tests (#125) * Removed .only from dash_test.ts * Production build instead of dev 🙈 * Fix failing tests * 3.1 refactor cells rendering (#123) * WIP - memoize cell event handlers as derived values - isolate cell event handlers * wip - attempt to isolate cell logic from input logic for individual datum * wip - celan up cell wrapper - isolate input logic a bit more * further down the rabbit hole.. - separating operation cells from content * fix dropdown navigation regression * fix selected row regression * renaming / restructuring * rename/restructure * - clean up zipping - separate wrappers from styles * rework style/ast cache * clean up * clean up * build update * improve rendering perf * optimize wrappers generation * build config * - fix typing regression - fix rendering perf regression * - fix navigation regression * simplify slightly the derived props / ui * fix copy/paste regressions * clean up wrapper props * clean up * fix regression on conditional dropdowns * wip, fp the headers * fp content, wrappers, labels, indices from header factory * fix regressions * fp the table itself * fix typing and behavior for table fp * fix sorting icon regression * fix regression * regression * fix column name regression with only 1 header row * fix header actions regression * fix style application on mount * fix regression edit cell in n-th page * fix editing on non-first page (continued) * fix test * 3.1 issue118 width behavior (#130) * WIP - memoize cell event handlers as derived values - isolate cell event handlers * wip - attempt to isolate cell logic from input logic for individual datum * wip - celan up cell wrapper - isolate input logic a bit more * further down the rabbit hole.. - separating operation cells from content * fix dropdown navigation regression * fix selected row regression * renaming / restructuring * rename/restructure * - clean up zipping - separate wrappers from styles * rework style/ast cache * clean up * clean up * build update * improve rendering perf * optimize wrappers generation * build config * - fix typing regression - fix rendering perf regression * - fix navigation regression * simplify slightly the derived props / ui * fix copy/paste regressions * clean up wrapper props * clean up * fix regression on conditional dropdowns * wip, fp the headers * fp content, wrappers, labels, indices from header factory * fix regressions * fp the table itself * fix typing and behavior for table fp * fix sorting icon regression * fix regression * regression * fix column name regression with only 1 header row * fix header actions regression * add width percentage support + content_style * fix style application on mount * fix visual regression with empty df * only apply row style when necessary * fix tab test (no offset) * clean up header styling * use dash-* classes * support default column width (override input behavior) * fix regression edit cell in n-th page * fix editing on non-first page (continued) * fix test * fit to content behavior * fix regressions * fix lint * add column width visual tests * fix dropdown minimum size when using default width * sizing examples * black * fix navigation test regression * fix regressions in visual tests * default column width - fix dropdown width eval * default width columns - fix width when first content row is search filter * percy - add delay before screenshot (attempt to fix FF visual tests) * debugging selenium * fix black * debug selenium * debug selenium * fix black * debug selenium * debug selenium * debug selenium * undo all selenium modifications * default column width - filter inputs behave like cell inputs (do not affect width) * - fixed rows+columns height evaluated correctly * remove dead code * remove .only from tests * add data-dash-column to filter cells * styling examples (#117) * 🌈 styling examples examples that represent of the level of customization that we need in dash-table. The examples are implemented with HTML tables to demonstrate the intended behaviour. I’d like to see each of these examples implemented with the `dash_table` syntax. We’ll use these examples as our `dash-table` documentation * ❌ removing black and pylint this keeps tripping us up and I don’t think it’s worth the pain right now. * Backend examples (#119) * 🏭 backend computed data usage examples * 📊 tying it together w a graph * ❓ not sure what `displayed_pages` does? * Dropdown usage examples (#120) * ⬇️ dropdown usage examples * add conditional dropdown example * - additional tests for editable/readonly - fixes for editable/readonly * bump version * remove useless test column * add editable prop to fixtures * update tests to take into account readonly 'rows' column * - refactor column isEditable calculation

Marc-André Rivet added 30 commits September 20, 2018 10:39

refactor virtualization, virtualization settings, and derived props

7394393

refactor renaming paging / pagination props

81e0802

refactor virtual, viewport and pagination into adapters

646068b

isolate derived props

3b13dbb

build update

4e0ecad

fix regression

fadbe4b

improve typing

8c60f0b

fix test regression

7013574

simplify pagination adapter / refactor

b606834

lint

ec68944

clean up unused props

ba80945

- change factory

f9ce473

- clean up props / build update

Merge remote-tracking branch 'origin/master' into 3.0-props-refactoring

78a1844

# Conflicts: # dash_table/bundle.js # dash_table/demo.js

fix lint

452de9b

bump version

8ec667e

add dash level props for virtual_dataframe

b334918

cleaup offsets

1ad6d66

triad validation

651682f

- define external facing classes and attributes

3a8e448

fix regression, update build

1c39abb

fix test regression (invalid props)

b559a47

update test name

77c21b4

refactor fp / derived props

80a2c02

derived props

2b674ee

refactor viewport and virtual controlled props

b2fc917

fix fp regression

6ba5403

fix fp regression

e546390

refactor controlled table / table fp

a520da6

controlled table purecomponent

d9e294d

fix test (rebrake it!)

770effa

Marc-André Rivet added 9 commits September 24, 2018 12:44

remove useless spy

5af4a70

Merge remote-tracking branch 'origin/3.0-props-refactoring' into 3.0-…

dd70844

…clean-offsets # Conflicts: # tests/e2e/cypress/integration/dash_test.ts

- control columns into visible columns

7414d0b

- cleanup "hidden" conditional processing

update changelog

71a09a8

clean up header factory

9e89e8d

apply style on first controlled table render

4d71b40

typo/merge miss

3e53af1

Marc-Andre-Rivet requested a review from valentijnnieman September 25, 2018 17:39

Marc-Andre-Rivet commented Sep 25, 2018

View reviewed changes

chriddyp temporarily deployed to dash-table-review-pr-110 September 25, 2018 17:39 Inactive

Marc-Andre-Rivet commented Sep 25, 2018

View reviewed changes

derived visible columns

0304c69

chriddyp temporarily deployed to dash-table-review-pr-110 September 25, 2018 17:51 Inactive

valentijnnieman approved these changes Sep 25, 2018

View reviewed changes

- visual tests for hidden columns

16730e5

chriddyp temporarily deployed to dash-table-review-pr-110 September 25, 2018 18:51 Inactive

rename functions

6ffd3c2

chriddyp temporarily deployed to dash-table-review-pr-110 September 25, 2018 18:56 Inactive

- fix dropdown styling regression

d38c599

chriddyp temporarily deployed to dash-table-review-pr-110 September 25, 2018 19:42 Inactive

lint

8be5143

chriddyp deployed to dash-table-review-pr-110 September 25, 2018 19:44 View deployment

Marc-Andre-Rivet merged commit 7bece90 into develop Sep 25, 2018

Marc-Andre-Rivet deleted the 3.0-clean-offsets branch October 12, 2018 13:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3.0 clean offsets #110

3.0 clean offsets #110

Marc-Andre-Rivet commented Sep 25, 2018

Marc-Andre-Rivet Sep 25, 2018

Marc-Andre-Rivet Sep 25, 2018

Marc-Andre-Rivet Sep 25, 2018

Marc-Andre-Rivet Sep 25, 2018

valentijnnieman left a comment

valentijnnieman Sep 25, 2018

Marc-Andre-Rivet Sep 25, 2018

valentijnnieman Sep 25, 2018

Marc-Andre-Rivet Sep 25, 2018

3.0 clean offsets #110

3.0 clean offsets #110

Conversation

Marc-Andre-Rivet commented Sep 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valentijnnieman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment