This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Issue 284 - Add source map to NPM and PyPi packages #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Andre-Rivet
commented
Dec 6, 2018
| "no-console": false | ||
| }, | ||
| "rulesDirectory": [] | ||
| } |
There was a problem hiding this comment.
Solving small issues with tslint rules in toolchain subfolders. Not related to main issue.. want to be able to use console.log in toolchain!
Marc-Andre-Rivet
commented
Dec 6, 2018
| @@ -21,18 +21,19 @@ module.exports = (preprocessor = {}, mode = 'development') => { | |||
| library: dashLibraryName, | |||
| libraryTarget: 'umd' | |||
| }, | |||
| devtool: 'source-map', | |||
There was a problem hiding this comment.
All is tslint fixes except for this. This setting is slower but more accurate than other mappings. See here: https://webpack.js.org/configuration/devtool/
Marc-Andre-Rivet
commented
Dec 6, 2018
| @@ -1,4 +1,5 @@ | |||
| include dash_table/bundle.js | |||
| include dash_table/bundle.js.map | |||
There was a problem hiding this comment.
PyPi addition
Marc-Andre-Rivet
commented
Dec 6, 2018
dash_table/__init__.py
Outdated
| 'external_url': ( | ||
| 'https://unpkg.com/dash-table@{}/dash_table/bundle.js.map' | ||
| ).format(__version__), | ||
| 'namespace': package_name |
Marc-Andre-Rivet
commented
Dec 6, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "dash-table", | |||
| "version": "3.1.8", | |||
| "version": "3.1.9", | |||
There was a problem hiding this comment.
bump version
Marc-Andre-Rivet
commented
Dec 6, 2018
| @@ -76,7 +76,7 @@ | |||
| "webpack-preprocessor": "^0.1.12" | |||
| }, | |||
| "files": [ | |||
| "/dash_table/bundle*.js" | |||
| "/dash_table/bundle*{.js,.map}" | |||
There was a problem hiding this comment.
pickup both js and map files for the NPM package
valentijnnieman
approved these changes
Dec 6, 2018
dash_table/__init__.py
Outdated
| 'external_url': ( | ||
| 'https://unpkg.com/dash-table@{}/dash_table/bundle.js.map' | ||
| ).format(__version__), | ||
| 'namespace': package_name |
…-map # Conflicts: # CHANGELOG.md # dash_table/bundle.js # dash_table/demo.js # dash_table/package-info.json # package-lock.json # package.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
Relates to plotly/dash#478
Relates to plotly/dash-renderer#104
Relates to plotly/dash-core-components#404