Ensure that only the visible columns are exported. #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shammamah-zz
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
shammamah-zz
commented
Sep 30, 2019
| const wb = createWorkbook(ws); | ||
| if (export_format === ExportFormat.Xlsx) { | ||
| XLSX.writeFile(wb, 'Data.xlsx', {bookType: 'xlsx', type: 'buffer'}); | ||
| XLSX.writeFile(wb, 'Data.xlsx', { bookType: 'xlsx', type: 'buffer' }); |
There was a problem hiding this comment.
These diffs come from the linter -- I can remove them if necessary.
There was a problem hiding this comment.
I think this PR is redundant with what's been done here #592. See https://github.com/plotly/dash-table/blame/dev/src/dash-table/components/Export/utils.tsx#L59 for column filtering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #553.