This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
React 16.13 #713
Merged
React 16.13 #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .circleci/config.yml
alexcjohnson
reviewed
Mar 6, 2020
| @@ -132,7 +132,7 @@ export default class ControlledTable extends PureComponent<ControlledTableProps> | |||
| this.handleResize(); | |||
| } | |||
|
|
|||
| componentWillMount() { | |||
| UNSAFE_componentWillMount() { | |||
There was a problem hiding this comment.
Is there a reason these listeners can't just go in componentDidMount?
alexcjohnson
reviewed
Mar 6, 2020
| @@ -146,7 +146,7 @@ export default class ControlledTable extends PureComponent<ControlledTableProps> | |||
| document.removeEventListener('paste', this.handlePaste); | |||
| } | |||
|
|
|||
| componentWillUpdate() { | |||
| UNSAFE_componentWillUpdate() { | |||
There was a problem hiding this comment.
Likewise, why not put this one in componentDidUpdate?
alexcjohnson
reviewed
Mar 6, 2020
| # Wait for table | ||
| WebDriverWait(dash_duo.driver, _TIMEOUT).until( | ||
| EC.presence_of_element_located((By.CSS_SELECTOR, "#{}".format(IDS["table"]))) | ||
| ) |
There was a problem hiding this comment.
Why not just dash_duo.wait_for_element("#{}".format(IDS["TABLE"])?
alexcjohnson
reviewed
Mar 6, 2020
|
|
||
| from selenium.webdriver.common.by import By | ||
| from selenium.webdriver.support import expected_conditions as EC | ||
| from selenium.webdriver.support.wait import WebDriverWait |
There was a problem hiding this comment.
Now you can get rid of these too, right? Which I'd have thought flake8 would have told you but perhaps it's not run on the test code...
There was a problem hiding this comment.
You're right, it's apparently not run on the tests folder
Marc-Andre-Rivet
commented
Mar 6, 2020
| @@ -1,5 +1,5 @@ | |||
| [flake8] | |||
| ignore = E203, E266, E501, E731, W503 | |||
| ignore = C901, E203, E266, E501, E731, W503 | |||
There was a problem hiding this comment.
Don't flag methods that are "too complex", we can decide that ourselves.. especially for tests!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to plotly/dash#1145