Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Improve error message for invalid filter queries #758

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Improve error message for invalid filter queries #758

merged 3 commits into from
Apr 21, 2020

Conversation

chriddyp
Copy link
Member

This is what it looks like now:
image

This PR improves this by:

  1. Remove "unable to evaluate target" - Not clear as a Dash dev what this is referring to
  2. Remove the = since there might be an = in the filter query itself, leading to an error message that has two = signs which is confusing
  3. Mentioning DataTable for specificity

Marc-Andre-Rivet
Marc-Andre-Rivet approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 with a changelog entry

@chriddyp chriddyp merged commit 88613cb into dev Apr 21, 2020
@chriddyp chriddyp deleted the chriddyp-patch-2 branch April 21, 2020 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Marc-Andre-Rivet Marc-Andre-Rivet Marc-Andre-Rivet approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

Assignees
No one assigned
Labels
dash-attribute-learnability dash-type-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chriddyp @Marc-Andre-Rivet