This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Re-render on changes to undefined props #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -152,5 +152,8 @@ def update_graph(rows, selected_rows): | |||
| dash_duo.wait_for_element("#waitfor") | |||
|
|
|||
| dash_duo.wait_for_element("#{}".format(IDS["table"])) | |||
| dash_duo.wait_for_element("#pop svg") | |||
| dash_duo.wait_for_element("#lifeExp svg") | |||
| dash_duo.wait_for_element("#gdpPercap svg") | |||
There was a problem hiding this comment.
Slight changes in timing / rendering require the test to be more specific and wait for the graph to be ready
Marc-Andre-Rivet
changed the title
Marc-Andre-Rivet
changed the title
|
@alexcjohnson With plotly/dash#1254 merged, the fix is now necessary. |
| }); | ||
|
|
||
| it('should update on undefined -> defined state', () => { | ||
| assert(shouldComponentUpdate({}, {}, {}, { a: 0 })); |
There was a problem hiding this comment.
This test fails without the added ...nextProps 8849e85#diff-aa707fa377faf64638e062a12fb52d85R13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For callback chain testing purposes. Also fixes a bug that causes the table to not re-render when a prop goes from being undefined -> defined.