-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering tests for the demos and add images to README #12
Conversation
6b86866
to
0d0caa3
Compare
@jourdain the tests are failing. Can you see them? |
|
Did you add |
I did for vtk, color_maps is local to the directory. |
I'll move colormap to the utils at some point... Working the quarks now... |
No worries. Feel free to push to this branch and merge this when you are done! |
Several fix went to master. The preset/colormaps is now part of dash_vtk.util. I've fixed the import in the demos... |
Don't forget to re-run |
Seems like there's an error with |
Ok looks like the problems went away. @jourdain I'm gonna merge this but I just wanted to make sure you are able to view the percy changes before merging; let me know! |
LGTM, what is |
@jourdain if you click on the "percy/dash-vtk - 5 visual changes need review" can you see the changes? |
Where do I find |
Ok I just enabled it (was a bit counter-intuitive) you should be able to see it now along with the circleci tests! |
I see the |
No, just wanted to make sure it works! Gonna merge now |
About
Description of changes
Pre-Merge checklist
npm run build
.Reference Issues
Closes #[issue number]
Other comments