Refactor demos - Remove unused files, change requirements linking, remove headers #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhluca
requested review from
alexcjohnson,
jourdain and
Marc-Andre-Rivet
as code owners
jourdain
approved these changes
Jan 30, 2021
|
After reflecting about it, I feel it's better to only keep an explorer app in the Let me know if you'd prefer seeing the explorer app in this repo as well and I'll add it back). |
xhluca
changed the title
added 4 commits
February 1, 2021 13:22
Changing it to avoid duplicate in multi-page (wrt other apps with the same ID)
Procfile and runtime.txt are not needed to run those demo, only for hosting
Move the requirements.txt to demos, and link to that file from tests/requirements.txt
added 7 commits
February 1, 2021 18:56
- Remove bootstrap dependencies - Decrease subset - Remove Columns/Rows
- Change row heights to % - Remove title - Change vtk height/width to %
- Change vtk height/width to %
- Change row heights to % - Remove title - Change vtk height/width to %
- Change row heights to % - Remove title - Change vtk height/width to %
- Change vtk height/width to %
- change card style from vh to % - change row height to % - Remove title - change controls to vertically centered
|
I think I'm happy with the refactoring of the apps; @jourdain Let me know if you'd like to review it again; if not I'll just merge it away |
|
LGTM you can merge it when ever you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Description of changes
Pre-Merge checklist
npm run build.Reference Issues
Closes #[issue number]
Other comments