Skip to content

Commit

Permalink
Remove len cache bust from resources, integrate with hot-reload later.
Browse files Browse the repository at this point in the history
  • Loading branch information
T4rk1n committed Nov 5, 2018
1 parent 37c7e15 commit 49e6a96
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions dash/resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@ def __init__(self, resource_name, layout):
self._resources = []
self.resource_name = resource_name
self.layout = layout
self._cache = {
'resources': [],
'len': 0
}
self._resources_cache = []

def append_resource(self, resource):
self._resources.append(resource)
Expand Down Expand Up @@ -62,16 +59,14 @@ def _filter_resources(self, all_resources, dev_bundles=False):
return filtered_resources

def get_all_resources(self, dev_bundles=False):
cur_len = len(self._resources)
if self._cache['resources'] and cur_len == self._cache['len']:
return self._cache['resources']
if self._resources_cache:
return self._resources_cache

all_resources = ComponentRegistry.get_resources(self.resource_name)
all_resources.extend(self._resources)

self._cache['resources'] = res = \
self._resources_cache = res = \
self._filter_resources(all_resources, dev_bundles)
self._cache['len'] = cur_len
return res


Expand Down

0 comments on commit 49e6a96

Please sign in to comment.