Merge pull request #915 from stevej2608/stevej2608

dash-generate-components crashes on windows
plotly · Sep 9, 2019 · c702899 · c702899
2 parents 6baf984 + b0c4d37
commit c702899
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/dash/development/component_generator.py b/dash/development/component_generator.py
@@ -58,8 +58,9 @@ def generate_components(
     reserved_patterns = "|".join("^{}$".format(p) for p in reserved_words)
 
     os.environ["NODE_PATH"] = "node_modules"
+
     cmd = shlex.split(
-        "node {} {} {} {}".format(
+        'node {} "{}" "{}" {}'.format(
             extract_path, ignore, reserved_patterns, components_source
         ),
         posix=not is_windows,

diff --git a/dash/extract-meta.js b/dash/extract-meta.js
@@ -5,7 +5,7 @@ const path = require('path');
 const reactDocs = require('react-docgen');
 
 const componentPaths = process.argv.slice(4);
-const ignorePattern = new RegExp(process.argv[2]);
+const ignorePattern = new RegExp(process.argv[2].split('"').join(''));
 const reservedPatterns = process.argv[3].split('|').map(part => new RegExp(part));
 
 let failed = false;