Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests for missing favicon.ico cause dash's index route to be served #152

Closed
ned2 opened this issue Oct 30, 2017 · 5 comments
Closed

requests for missing favicon.ico cause dash's index route to be served #152

ned2 opened this issue Oct 30, 2017 · 5 comments

Comments

@ned2
Copy link
Contributor

ned2 commented Oct 30, 2017

I just noticed that when a favicon is not wired up, the automatic request for /favicon.ico by the browser results in the dash server returning its index route. This seems to be a consequence of there being a catchall redirecting all URLs that are not matched to the index route.

While probably not too harmful, this seems undesirable. One solution could be to include a default favicon, but perhaps it is also worth establishing whether the catchall behaviour is desirable?

@ned2 ned2 changed the title failed requests for favicon cause dash's index route to be served requests for missing favicon.ico cause dash's index route to be served Oct 30, 2017
@rmarren1
Copy link
Contributor

I like the idea of having a default favicon, maybe the Dash logo? Or we can just add a default route for favicon.ico in Dash that returns nothing when there is no favicon.ico in the assets directory

@chriddyp
Copy link
Member

Yeah, I like the idea of a built-in Dash favicon too.

@T4rk1n
Copy link
Contributor

T4rk1n commented Sep 25, 2018

I think including a default dash favicon.ico is better than a 404.

@chriddyp
Copy link
Member

Here are some favicons we could use
dash-favicons.zip

@T4rk1n T4rk1n self-assigned this Sep 26, 2018
@T4rk1n
Copy link
Contributor

T4rk1n commented Sep 26, 2018

I will add the favicon.ico in the zip as the default favicon.

@T4rk1n T4rk1n mentioned this issue Sep 26, 2018
Dash - A Pleasant and Productive Developer Experience automation moved this from To do to Done Sep 26, 2018
byronz added a commit that referenced this issue Apr 23, 2019
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this issue May 28, 2021
Replace all instances of plot.ly with plotly.com.
HammadTheOne pushed a commit that referenced this issue Jul 23, 2021
Replace all instances of plot.ly with plotly.com.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants