Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events are broken; base_component.parse_events needs updating #232

Closed
ned2 opened this issue Mar 25, 2018 · 1 comment
Closed

Events are broken; base_component.parse_events needs updating #232

ned2 opened this issue Mar 25, 2018 · 1 comment

Comments

@ned2
Copy link
Contributor

ned2 commented Mar 25, 2018

Moving from dash-html-components==0.9.0rc1 to dash-html-components==0.9.0 causes any callbacks using click Events to break as Dash._validate_callback now raises a NonExistantEventException. This appears to be because base components are now generated with available_events = []. This is due to base_component.parse_events not being updated to handle the new PropType data structure used to define Component props created by dash_html_components and dash_core_components.

This is also causing the tests to fail now, as invocation of a callback with a valid event in test_exception_event_not_in_component is now failing. So would be good to prioritise this.
@ned2 ned2 mentioned this issue Mar 30, 2018
Closed
@rmarren1 rmarren1 mentioned this issue Mar 30, 2018
Merged
@ned2 ned2 mentioned this issue Apr 15, 2018
Closed
chriddyp added a commit to plotly/dash-renderer that referenced this issue Apr 30, 2018
@chriddyp
temp remove events tests
e61da56 
events have been broken since plotly/dash#232
chriddyp added a commit to plotly/dash-renderer that referenced this issue Jun 1, 2018
@chriddyp
temp remove events tests
ff5b4b2 
events have been broken since plotly/dash#232
@ned2
Copy link
Contributor Author

ned2 commented Feb 5, 2019

Events have now been removed from Dash

@ned2 ned2 closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ned2