Improve Callback Graph #1179
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| from multiprocessing import Value | ||
|
|
||
| import dash | ||
| from dash.dependencies import Input, Output, State, MATCH, ALL, ALLSMALLER | ||
| import dash_html_components as html | ||
| import dash_core_components as dcc | ||
|
|
||
|
|
||
| def todo_app(content_callback=False): | ||
| app = dash.Dash(__name__) | ||
|
|
||
| content = html.Div( | ||
| [ | ||
| html.Div("Dash To-Do list"), | ||
| dcc.Input(id="new-item"), | ||
| html.Button("Add", id="add"), | ||
| html.Button("Clear Done", id="clear-done"), | ||
| html.Div(id="list-container"), | ||
| html.Hr(), | ||
| html.Div(id="totals"), | ||
| ] | ||
| ) | ||
|
|
||
| if content_callback: | ||
| app.layout = html.Div([html.Div(id="content"), dcc.Location(id="url")]) | ||
|
|
||
| @app.callback(Output("content", "children"), [Input("url", "pathname")]) | ||
| def display_content(_): | ||
| return content | ||
|
|
||
| else: | ||
| app.layout = content | ||
|
|
||
| style_todo = {"display": "inline", "margin": "10px"} | ||
| style_done = {"textDecoration": "line-through", "color": "#888"} | ||
| style_done.update(style_todo) | ||
|
|
||
| app.list_calls = Value("i", 0) | ||
| app.style_calls = Value("i", 0) | ||
| app.preceding_calls = Value("i", 0) | ||
| app.total_calls = Value("i", 0) | ||
|
|
||
| @app.callback( | ||
| Output("list-container", "children"), | ||
| Output("new-item", "value"), | ||
| Input("add", "n_clicks"), | ||
| Input("new-item", "n_submit"), | ||
| Input("clear-done", "n_clicks"), | ||
| State("new-item", "value"), | ||
| State({"item": ALL}, "children"), | ||
| State({"item": ALL, "action": "done"}, "value"), | ||
| ) | ||
| def edit_list(add, add2, clear, new_item, items, items_done): | ||
| app.list_calls.value += 1 | ||
| triggered = [t["prop_id"] for t in dash.callback_context.triggered] | ||
| adding = len( | ||
| [1 for i in triggered if i in ("add.n_clicks", "new-item.n_submit")] | ||
| ) | ||
| clearing = len([1 for i in triggered if i == "clear-done.n_clicks"]) | ||
| new_spec = [ | ||
| (text, done) | ||
| for text, done in zip(items, items_done) | ||
| if not (clearing and done) | ||
| ] | ||
| if adding: | ||
| new_spec.append((new_item, [])) | ||
| new_list = [ | ||
| html.Div( | ||
| [ | ||
| dcc.Checklist( | ||
| id={"item": i, "action": "done"}, | ||
| options=[{"label": "", "value": "done"}], | ||
| value=done, | ||
| style={"display": "inline"}, | ||
| ), | ||
| html.Div( | ||
| text, id={"item": i}, style=style_done if done else style_todo | ||
| ), | ||
| html.Div(id={"item": i, "preceding": True}, style=style_todo), | ||
| ], | ||
| style={"clear": "both"}, | ||
| ) | ||
| for i, (text, done) in enumerate(new_spec) | ||
| ] | ||
| return [new_list, "" if adding else new_item] | ||
|
|
||
| @app.callback( | ||
| Output({"item": MATCH}, "style"), | ||
| Input({"item": MATCH, "action": "done"}, "value"), | ||
| ) | ||
| def mark_done(done): | ||
| app.style_calls.value += 1 | ||
| return style_done if done else style_todo | ||
|
|
||
| @app.callback( | ||
| Output({"item": MATCH, "preceding": True}, "children"), | ||
| Input({"item": ALLSMALLER, "action": "done"}, "value"), | ||
| Input({"item": MATCH, "action": "done"}, "value"), | ||
| ) | ||
| def show_preceding(done_before, this_done): | ||
| app.preceding_calls.value += 1 | ||
| if this_done: | ||
| return "" | ||
| all_before = len(done_before) | ||
| done_before = len([1 for d in done_before if d]) | ||
| out = "{} of {} preceding items are done".format(done_before, all_before) | ||
| if all_before == done_before: | ||
| out += " DO THIS NEXT!" | ||
| return out | ||
|
|
||
| @app.callback( | ||
| Output("totals", "children"), Input({"item": ALL, "action": "done"}, "value") | ||
| ) | ||
| def show_totals(done): | ||
| app.total_calls.value += 1 | ||
| count_all = len(done) | ||
| count_done = len([d for d in done if d]) | ||
| result = "{} of {} items completed".format(count_done, count_all) | ||
| if count_all: | ||
| result += " - {}%".format(int(100 * count_done / count_all)) | ||
| return result | ||
|
|
||
| return app |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| from time import sleep | ||
| import requests | ||
|
|
||
| import dash_html_components as html | ||
| import dash | ||
| from dash.dependencies import Output, Input | ||
|
|
||
|
|
||
| def test_dvct001_callback_timing(dash_thread_server): | ||
|
There was a problem hiding this comment. @rpkyle this test should cover parity between Python and R for the |
||
| app = dash.Dash(__name__) | ||
| app.layout = html.Div() | ||
|
|
||
| @app.callback(Output("x", "p"), Input("y", "q")) | ||
| def x(y): | ||
| dash.callback_context.record_timing("pancakes", 1.23) | ||
| sleep(0.5) | ||
| return y | ||
|
|
||
| dash_thread_server(app, debug=True, use_reloader=False, use_debugger=True) | ||
|
|
||
| response = requests.post( | ||
| dash_thread_server.url + "/_dash-update-component", | ||
| json={ | ||
| "output": "x.p", | ||
| "outputs": {"id": "x", "property": "p"}, | ||
| "inputs": [{"id": "y", "property": "q", "value": 9}], | ||
| "changedPropIds": ["y.q"], | ||
| }, | ||
| ) | ||
|
|
||
| # eg 'Server-Timing': '__dash_server;dur=505, pancakes;dur=1230' | ||
| assert "Server-Timing" in response.headers | ||
| st = response.headers["Server-Timing"] | ||
| times = {k: int(v) for k, v in [p.split(";dur=") for p in st.split(", ")]} | ||
| assert "__dash_server" in times | ||
| assert times["__dash_server"] >= 500 # 0.5 sec wait | ||
| assert "pancakes" in times | ||
| assert times["pancakes"] == 1230 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New feature for
dash.testing-percy_snapshotadds a kwargconvert_canvasesthat turns every<canvas>into an<img>with matching contents, then puts the canvases back afterward. This lets us capture Cytoscape, among other things (cc @xhlulu)Sizing isn't quite as expected, but I assume that's just Percy rendering as a different screen size from what's used in circleci.