-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Callback Graph #1179
Merged
Merged
Improve Callback Graph #1179
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
6d9cdfd
Move callback graph to cytoscape and add clientside coloring
18539a2
Update styling and add live component and callback introspection
45c3b98
Add State to the callback graph with dashed lines
5d99381
Remove redundant value fields in introspection data
42c7664
Change to BFS layout for better State support
d4652ca
Add store and reducers for callback profiling and change notifications
5a4b996
Connect CallbackGraph to profiling and change notifications
221d4ba
Add basic profiling and execution highlighting
a89994b
Cleanup effects and highlight the sub-callback graph on select.
1fbd48c
Add support for Server-Timing headers and resource timing API
147d3be
Fix error when callback selected before first run.
2e2215c
Switch to react-json-tree because of bugs
6390f01
Update JSON styling
8553fb6
Merge remote-tracking branch 'upstream/dev' into callback_graph. Brea…
0b24da2
Partial implementation of wildcards. Introspection is broken.
5fa1850
Merge branch 'dev' into callback_graph
alexcjohnson 2ad16f3
Merge branch 'dev' into callback_graph
alexcjohnson 06f051b
callback graph merge fixes, and restrict profiling to debug mode
alexcjohnson c480342
incorporate callback status in profiling
alexcjohnson 2026f10
error boundary for callback graph
alexcjohnson c67bd64
basic callback graph + pattern-matching fix
alexcjohnson c24a8e1
callback graph compatibility with hot reloading
alexcjohnson c89bd92
avoid errors on callback graph info for pattern-matching callbacks
alexcjohnson 0f4924e
Merge branch 'dev' into callback_graph
alexcjohnson 39ee385
lint js
alexcjohnson 19de6ec
prettier + tslint via tslint-config-prettier
alexcjohnson 8be31bf
fix profiler with unresponsive server
alexcjohnson d6325a6
lint profile reducer again??
alexcjohnson a2c6db4
black for callback profiling
alexcjohnson 5ba3378
callback graph - respect effect cleanup
alexcjohnson 97f4bee
pylint callback profiling
alexcjohnson 244c6a4
only add callback profiling in debug mode with ui
alexcjohnson 712b8df
Merge branch 'dev' into callback_graph
alexcjohnson cd54525
js/py->client/server & fix displayed count/time
alexcjohnson fd749c8
clean up callback graph styles & profile report
alexcjohnson 5c927f0
fix callback graph info for missing IDs
alexcjohnson fc967a4
use dagre, cache layout, and save it when users pan/zoom/move nodes
alexcjohnson 21d1e70
prettier
alexcjohnson 3cbd990
get callback inputs/outputs from request/response, not layout
alexcjohnson bd8a752
fix history -> undo/redo
alexcjohnson 0cec93f
display average times and bytes, not totals, in callback profiles
alexcjohnson 5bda9d8
Merge branch 'dev' into callback_graph
alexcjohnson fdde1f1
changelog for callback graph improvements
alexcjohnson e9977d6
lint setting tweaks - and include tsx
alexcjohnson da76ae0
map w/ no return -> forEach
alexcjohnson df041e1
don't move the graph when selecting a node
alexcjohnson fe759e8
Merge branch 'dev' into callback_graph
alexcjohnson f6ac62b
black
alexcjohnson ef7b60c
fiddling with cb graph layout
alexcjohnson 75160ce
Merge branch 'dev' into callback_graph
alexcjohnson 65e14c5
user-selectable callback graph layout algos
alexcjohnson 6ee83d5
callback graph tests
alexcjohnson 18035a7
Merge branch 'dev' into callback_graph
alexcjohnson 4b10e65
py2 test fix?
alexcjohnson 02bbe5f
Merge branch 'dev' into callback_graph
alexcjohnson fd28d05
fix changelog
alexcjohnson ec345d3
Update CHANGELOG.md
Marc-Andre-Rivet 8af36d5
fix bad merge on requestedCallbacks.ts
fdc662e
trigger build
a710e5f
update dash-test-components lock file
607773d
trigger build
c065fd2
trigger build
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolaskruchten I couldn't come up with a single layout that always seemed better than the others, so made a dropdown to choose among three. Another side benefit of this is if you drag nodes around to tweak the layout, and you want to get back to the original, you can change to a different algo and then back to the original.