Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dash logger.setLevel to init + remove now redundant startup message #1355

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

anders-kiaer
Copy link
Contributor

@anders-kiaer anders-kiaer commented Aug 4, 2020

Resolves #1354.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Move setLevel to __init__
    • Remove two now redundant messages.
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

Optionals

  • I have added entry in the CHANGELOG.md (not added, this PR probably is not regarded as a "notable change", let me know if an entry should be added).
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follow
    • this github #PR number updates the dash docs
    • here is the show and tell thread in plotly dash community

@anders-kiaer anders-kiaer force-pushed the dash_logger branch 3 times, most recently from d303943 to c3b50c0 Compare August 4, 2020 20:21
@anders-kiaer anders-kiaer marked this pull request as ready for review August 4, 2020 20:31
@alexcjohnson
Copy link
Collaborator

Nice! Actually I do think this warrants a changelog entry since it enables users to do something new. Something like:

Removed redundant log message and consolidated logger initialization. You can now control the log level - for example suppress informational messages from Dash with app.logger.setLevel(logging.WARNING).

(I don't think it's even necessary to say when you can use setLevel, since it's anytime after you have an app object and before you run the server)

@anders-kiaer
Copy link
Contributor Author

anders-kiaer commented Aug 4, 2020

👍 Agree - new changelog entry added 📜 🔖 Not sure if it belongs as an "Added" entry or a "Fixed" entry (it adds new configuration possibility with setLevel, but does that mainly through a small fix).

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks! 💃

@alexcjohnson alexcjohnson merged commit 44a45fc into plotly:dev Aug 5, 2020
@anders-kiaer anders-kiaer deleted the dash_logger branch August 5, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Possibility to configure Dash logger level
2 participants