Callback graph robustness #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import PropTypes from 'prop-types'; | ||
| import React, { Fragment } from 'react'; | ||
|
|
||
| const WidthComponent = props => (<Fragment> |
There was a problem hiding this comment.
Callback graph fails against components with width prop.. simple component with width
| dash_duo.find_element(".dash-debug-menu__button--callbacks").click() | ||
| sleep(3) # wait for callback graph to draw | ||
|
|
||
| assert dash_duo.get_logs() == [] |
There was a problem hiding this comment.
Some test with a callback involving a width prop. Fails against dash-renderer==1.8.1
Marc-Andre-Rivet
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
@alexcjohnson If you're 💃 with the test, I'm 💃 with the code change 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback graph barfs on some apps, for two reasons:
widththe Dagre layout throws an error the way we constructed our graph elements. I just mangled the props in the graph element IDs to fix this.rankerfrom the defaultnetwork-simplextotight-treeappears to be more robust and gives generally comparable results.In addition, I switched the force layout to
fcose, which is more powerful than the built-incose, I gave it stronger coupling between props in a single component to group them closer together, and I added a modeforce-loosethat skips that stronger coupling in case that works better in some circumstances.I didn't add any tests of the new behavior, as I couldn't find a simple and public app that has problems previously.