Patch 3 - Update Python code to further follow Pylint standards #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask import Flask, Response". Standard import "import importlib" should be placed before "from flask import Flask, Response". Standard import "import json" should be placed before "from flask import Flask, Response". Standard import "import pkgutil" should be placed before "from flask import Flask, Response". Standard import "import warnings" should be placed before "from flask import Flask, Response" (wrong-import-order). All seen from Pylint
…ase_component import generate_class". Standard import "import json" should be placed before "from .base_component import generate_class". (wrong-import-order)
…Standard import "import pkgutil" should be placed before "import dash". (wrong-import-order) Also fix indentation.
…resources import Scripts, Css". Standard import "import warnings" should be placed before "from dash.resources import Scripts, Css" (wrong-import-order).
…lopment.component_loader import load_components". Standard import "import os" should be placed before "from dash.development.component_loader import load_components". Standard import "import unittest" should be placed before "from dash.development.component_loader import load_components" (wrong-import-order).
|
Thanks @jbampton ! |
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
…-prop-4.2.1 Bump dot-prop from 4.2.0 to 4.2.1
HammadTheOne
pushed a commit
that referenced
this pull request
Jul 23, 2021
…4.2.1 Bump dot-prop from 4.2.0 to 4.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly putting the import statements in the correct order.