Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dcc.Markdown prop 'link_target' #2034

Merged
merged 8 commits into from May 3, 2022
Merged

Conversation

adrianoesch
Copy link
Contributor

@adrianoesch adrianoesch commented May 3, 2022

This PR is adding the prop link_target to dcc.Markdown component, analogous to the behaviour in datatable and thereby closing #1827.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Figure out react-markdown integration
    • Add necessary props and documentation string
  • I have run the tests locally and they passed (though only dash-core-components markdown test).
  • I have added a test.

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@alexcjohnson
Copy link
Contributor

Beautiful, with a test and everything 😍
Just add a changelog entry and we'll merge.

@adrianoesch
Copy link
Contributor Author

Great! Just added the changelog.

@alexcjohnson
Copy link
Contributor

The Percy tests here are showing a problem (Python errors showing up in the browser as a raw string rather than rendered HTML) that I suspect is due to the latest Werkzeug release. It certainly isn't anything you did in this PR @adrianoesch, but I don't want to merge until we fix it so we don't lose the correct Percy baselines. @T4rk1n can you take a look at addressing this?

@T4rk1n
Copy link
Contributor

T4rk1n commented May 3, 2022

@alexcjohnson The doctype changed to all lowercase in werkzeug 2.1.2, I modified the check to accommodate all case in #2035

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants