Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed validation_layout in pages #2182

Merged
merged 8 commits into from Sep 8, 2022
Merged

fixed validation_layout in pages #2182

merged 8 commits into from Sep 8, 2022

Conversation

AnnMarieW
Copy link
Contributor

@AnnMarieW AnnMarieW commented Aug 4, 2022 •
edited

Closes #2172

Makes it so that when using pages, if suppress_callback_exceptions=True the validation_layout is not set.

alexcjohnson
alexcjohnson approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great - and yeah, cleaner to do this without the before_(first_)request part.

Please add a changelog note, then we'll merge 🎉

alexcjohnson
alexcjohnson reviewed Sep 8, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@alexcjohnson alexcjohnson mentioned this pull request Sep 8, 2022
Merged
5 tasks
@alexcjohnson alexcjohnson merged commit 3fe9d0f into plotly:dev Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make app validation optional when using pages
2 participants
@AnnMarieW @alexcjohnson