Component as props objectOf support. #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/integration/renderer/test_component_as_prop.py
T4rk1n
changed the title
Comment on lines
73
to
80
| Object.keys(childObj).forEach(key => { | ||
| const value = childObj[key]; | ||
| crawlLayout( | ||
| value, | ||
| func, | ||
| concat(currentPath, childPath.concat([key])) | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Not a big deal, just a little cleaner. Same at line 143
Suggested change
| Object.keys(childObj).forEach(key => { | |
| const value = childObj[key]; | |
| crawlLayout( | |
| value, | |
| func, | |
| concat(currentPath, childPath.concat([key])) | |
| ); | |
| }); | |
| for (const key in childObj) { | |
| const value = childObj[key]; | |
| crawlLayout( | |
| value, | |
| func, | |
| concat(currentPath, childPath.concat([key])) | |
| ); | |
| } |
Comment on lines
133
to
139
| dynamic_dict={"node": {"dict-dyn": Div("dict-dyn", id="inside-dict")}}, | ||
| dynamic_list=[ | ||
| {"list": Div("dynamic-list", id="inside-list")}, | ||
| ], | ||
| dynamic_nested_list=[ | ||
| {"obj": {"nested": Div("nested", id="nested-dyn")}} | ||
| ], |
There was a problem hiding this comment.
Pretty low risk, but if you wanted to cover all bases these props should get two keys & two list items to ensure we're properly looping over everything.
alexcjohnson
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2129