Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-cytoscapejs v2 and lint updates #2217

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Sep 2, 2022

Use new react-cytoscapejs@2.0.0 - from plotly/react-cytoscapejs#99 (cc @akx)
Supersedes #2133

@T4rk1n unclear why I need the lint updates here, yet CI was passing?

(probably doesn't need a changelog entry, as this has no user-facing consequences)

unclear why I'm needing these lint updates,
pretty sure my setup is correct?
@T4rk1n
Copy link
Contributor

T4rk1n commented Sep 6, 2022

@T4rk1n unclear why I need the lint updates here, yet CI was passing?

The linting for black seems to be broken:

> private::lint.black
> if [[ ${PYVERSION:-python39} != python36 ]]; then black dash tests --exclude metadata_test.py --check; fi

sh: 1: [[: not found

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit c897b2b into dev Sep 6, 2022
@alexcjohnson alexcjohnson deleted the react-cytoscape-v2 branch September 6, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants