Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps update 221021 #2282

Merged
merged 5 commits into from Oct 25, 2022
Merged

Deps update 221021 #2282

merged 5 commits into from Oct 25, 2022

Conversation

alexcjohnson
Copy link
Contributor

@alexcjohnson alexcjohnson commented Oct 24, 2022

Across-the-board depencency upgrades, including:

  • plotlyjs 2.13.3 -> 2.16.1

  • browserslist (as a subdependency): by default it now declares IE11 dead and excludes it, meaning default output is no longer es5. In fact, by default it now goes all the way to es2020. However, because we know Dash gets used by a substantial number of people in airgapped or otherwise highly restricted environments, I opted to go for a rule based on assuming laptops have ~7 year lifespan and are at least set up with current software when they're bought. So the browserslist query I settled on is: "last 7 years and not dead". That gives us es2015 compliant code.

  • I have added entry in the CHANGELOG.md

@alexcjohnson
Copy link
Contributor Author

Big pain solving this storybook issue storybookjs/storybook#18276 -> I'm not sure exactly which step fixed it (reinstalling with no npm cache, using latest node/npm were the main two) but it now seems to work. Still two versions of webpack installed in the test setup, that's inherent to storybook at this point, but some important part of it flipped from 4.x to 5.x in ab30dbe and that resolved the problem.

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit 38cd339 into dev Oct 25, 2022
@alexcjohnson alexcjohnson deleted the deps-update-221021 branch October 25, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants