Move flask_compress dependency to extras require #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. AFAICT none of our tests load Annoying that percy won't even show comparisons when they update FF on their side. But at least this PR has nothing to do with any of them so we can blindly approve. |
T4rk1n
force-pushed
the
compress-extra
branch
from
babae51
to
0d3264c
Compare
bandersen23
added a commit
to bandersen23/dash-feedstock
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion from #2286 (comment), this change the flask_compress dependency to an extra requires installed with
dash[compress]. This new requirement is needed when using thecompressargument of Dash.