Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing improvements #2417

Merged
merged 8 commits into from
Feb 14, 2023
Merged

Testing improvements #2417

merged 8 commits into from
Feb 14, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Feb 8, 2023

with pytest.raises(TimeoutException) as err:
dash_duo.wait_for_text_to_equal("#none", "None", timeout=1.0)

assert err.value.args[0] == "text -> None not found within 1.0s, #none not found"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, I've been thinking we should have useful error messages like this for a long time, thanks!

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@T4rk1n T4rk1n merged commit 6b27856 into dev Feb 14, 2023
@T4rk1n T4rk1n deleted the testing-improvments branch February 14, 2023 14:05
@RonnyPfannschmidt
Copy link

this breaks as hookwrapeprs are expectedto yield, and rightfuly so
see pytest-dev/pytest#10820

@RonnyPfannschmidt
Copy link

ah, already fixed via #2461 and reported in #2460

lovely 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants