Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logger to dash namespace, add stream handler once. #2425

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Feb 14, 2023

  • Moved the logger namespace to dash.dash, as library logger it should be on that namespace instead of the user app.
  • Fix multiple log handler added unconditionally to the logger, resulting in duplicate log message.
  • Add add_log_handler=True to Dash init, if you don't want a stream handler at all.

Fix #1099, Fix #756

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nicely done.
💃 with a changelog entry

@T4rk1n T4rk1n merged commit f99565f into dev Feb 15, 2023
@T4rk1n T4rk1n deleted the logging-fix branch February 15, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants