Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RadioItems & Checklist inline prop. #2450

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Fix RadioItems & Checklist inline prop. #2450

merged 6 commits into from
Mar 15, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Mar 10, 2023

Fix #2063
Set label style display: block if inline is false in RadioItems & Checklist components.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Hopefully this change doesn't upset too many people, but it does seem like the least disruptive thing we can do at this point!

Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
@T4rk1n T4rk1n merged commit 59fc9c5 into dev Mar 15, 2023
@T4rk1n T4rk1n deleted the fix-vertical branch March 15, 2023 20:03
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you know what, I don't think this test ran. I think it needs to be moved into tests/integration/misc to match the pattern in the CI config circleci tests glob "tests/integration/**/test_*.py"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RadioItems / Checklist does not display vertically as documented without stylesheet
2 participants