Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event listeners for Location on unmount #2489

Merged
merged 3 commits into from
Apr 12, 2023

Commits on Apr 11, 2023

  1. Remove event listeners for Location on unmount

    Currently, if the component is not mounted (e.g. because on a different page),
    the component will still receive the change event and the `onLocationChange`
    callback changes its props via `this.props.setProps` with the itempath from
    ('_dashprivate_path') in the DOM. The object, however, is
    not on the dom and a random other DOM element is assigned the changed props.
    
    The PR deregisters the event listeners of the component is unmounted. They will
    be added again via `componentDidMount` anyways if the component is mounted again.
    
    fixes plotly#1346
    jowlo committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    43debc1 View commit details
    Browse the repository at this point in the history
  2. Update Changelog

    jowlo committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    eda1a31 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Configuration menu
    Copy the full SHA
    55a5735 View commit details
    Browse the repository at this point in the history