Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clientside inline function name. #2491

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Fix clientside inline function name. #2491

merged 5 commits into from
Apr 4, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Mar 31, 2023

Fix #2488

@T4rk1n T4rk1n mentioned this pull request Mar 31, 2023
Closed
@RenaudLN
Copy link
Contributor

Nice fix, thanks :)

alexcjohnson
alexcjohnson approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 very nice. Just needs a changelog entry 😎

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Apr 3, 2023

The test works fine when running alone, but is unstable when running tests on the whole file.

@T4rk1n T4rk1n force-pushed the fix/#2488 branch 3 times, most recently from f3214a1 to 0f32f80 Compare April 4, 2023 14:00
@T4rk1n T4rk1n merged commit a6d9c99 into dev Apr 4, 2023
@T4rk1n T4rk1n deleted the fix/#2488 branch April 4, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Inline clientside_callback scripts not found in Dash 2.9.2
3 participants
@T4rk1n @RenaudLN @alexcjohnson