Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pages meta tags #2540

Merged
merged 9 commits into from
May 25, 2023
Merged

Fix pages meta tags #2540

merged 9 commits into from
May 25, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented May 24, 2023

  • Add include_pages_meta=True to Dash.__init__
  • Escape meta tags values
  • Refactor some pages methods on Dash to _pages.py

Fix #2536

@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner May 24, 2023 18:05
alexcjohnson
alexcjohnson reviewed May 24, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@alexcjohnson
Copy link
Collaborator

This looks great, can we just add a test? Doesn't need to be a browser test, just make a request with a junky URL and look at the page string that comes back.

T4rk1n and others added 3 commits May 24, 2023 16:19
@T4rk1n
Add back og:type
28de967
@T4rk1n
Fix twitter cards
43af904
@T4rk1n @alexcjohnson
Update CHANGELOG.md
2ed27f3 
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
@alexcjohnson alexcjohnson mentioned this pull request May 25, 2023
Closed
alexcjohnson
alexcjohnson approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@T4rk1n T4rk1n merged commit 7245896 into dev May 25, 2023
1 check passed
@T4rk1n T4rk1n deleted the fix/#2536 branch May 25, 2023 15:58
@etpinard etpinard mentioned this pull request Jun 28, 2023
Open
@alexcjohnson alexcjohnson mentioned this pull request Dec 5, 2023
Closed
@MukuFlash03 MukuFlash03 mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Turn twitter cards off by default to avoid security issues
2 participants
@T4rk1n @alexcjohnson