Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use julia --project in JuliaRunner #2573

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jun 21, 2023

Currently the JuliaRunner spawns a Dash.jl server using the julia executable with no option. This means the JuliaRunner expects the Julia test dependencies to be installed in the default environment, located e.g. in ~/.julia/environments/v1.9/.

While installing the Julia test dependencies in the default environment might be ok in a test container, it is not the recommended way to develop Julia packages.

Using the julia --project in the server-spawning command, makes the JuliaRunner use the test dependencies from the Dash.jl package environment, the same test dependencies we used in the Dash.jl unit tests.

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

instead of just `julia` to support
testing within Julia environments.
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Please add a changelog entry and we'll merge :)

@alexcjohnson alexcjohnson merged commit 7a58dab into plotly:dev Jun 27, 2023
3 checks passed
@etpinard etpinard deleted the use-julia-project-in-JuliaRunner branch June 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants