Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning if using JupyterDash #2579

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Add warning if using JupyterDash #2579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03e62cb
Add warning if using JupyterDash
T4rk1n Jun 28, 2023
e4fd7cf
Merge branch 'dev' into fix/jp-conflicts
T4rk1n Jun 28, 2023
a959be1
Update changelog.
T4rk1n Jun 28, 2023
2fec4b4
Add link to dash-in-jupyter in the warning.
T4rk1n Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
## Changed

- [#2573](https://github.com/plotly/dash/pull/2573) Use `julia --project` command inside `JuliaRunner`.
- [#2579](https://github.com/plotly/dash/pull/2579) Add warning if using `JupyterDash`

## [2.11.0] - 2023-06-23

Expand Down
7 changes: 7 additions & 0 deletions dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import sys
import collections
import importlib
import warnings
from contextvars import copy_context
from importlib.machinery import ModuleSpec
import pkgutil
Expand Down Expand Up @@ -511,6 +512,12 @@ def __init__( # pylint: disable=too-many-statements

self.logger.setLevel(logging.INFO)

if self.__class__.__name__ == "JupyterDash":
warnings.warn(
"JupyterDash is deprecated, use Dash instead.\n"
"See https://dash.plotly.com/dash-in-jupyter for more details."
)

def init_app(self, app=None, **kwargs):
"""Initialize the parts of Dash that require a flask app."""

Expand Down