Refactors #2635
Refactors #2635
Conversation
T4rk1n
force-pushed
the
optim/refact
branch
2 times, most recently
from
dd159eb
to
1f82f23
Compare
.circleci/config.yml
Outdated
| @@ -3,7 +3,7 @@ version: 2.1 | |||
| orbs: | |||
| win: circleci/windows@2.4.0 | |||
| percy: percy/agent@0.1.3 | |||
| browser-tools: circleci/browser-tools@1.4.3 | |||
| browser-tools: circleci/browser-tools@1.4.5 | |||
There was a problem hiding this comment.
There's a 1.4.6 now, but we can wait on that if this one works.
There was a problem hiding this comment.
oh maybe that would let us remove the chrome 116 pin?
There was a problem hiding this comment.
Yes I think that was fixed and there is also now a proper chromedriver version I think that was the cause for dvpc001 failures.
There was a problem hiding this comment.
I unpinned the chrome version and the dvpc was failing again.
There was a problem hiding this comment.
OK - please make an issue to come back to this
| @@ -216,3 +218,5 @@ def display_content(pathname): | |||
| assert dash_duo.get_logs(), tc | |||
| else: | |||
| assert dash_duo.get_logs() == [], tc | |||
|
|
|||
| time.sleep(0.1) | |||
There was a problem hiding this comment.
what effect does this sleep have, coming after all the assertions?
There was a problem hiding this comment.
This test was failing but I am not sure that it needs this.
T4rk1n
force-pushed
the
optim/refact
branch
from
389ee7b
to
d31b1cc
Compare
T4rk1n
force-pushed
the
optim/refact
branch
2 times, most recently
from
65397b4
to
8ae9488
Compare
dcc.Input,dcc.Textarea,dcc.Slider,dcc.RangeSlider