Drop 3.6 and 3.7 and support 3.11 and 3.12 #2735
Conversation
graingert-coef
force-pushed
the
drop-3-6-support-3-12
branch
5 times, most recently
from
98ef6b4
to
81ab7b5
Compare
|
Ah it's |
graingert-coef
force-pushed
the
drop-3-6-support-3-12
branch
2 times, most recently
from
3098285
to
ddf7a1b
Compare
| @@ -49,7 +49,7 @@ jobs: | |||
| name: 🏁 Build Component Packages & Update Dependencies/Artifacts | |||
| command: | | |||
| python -m venv venv && . venv/bin/activate | |||
| pip install --upgrade pip wheel | |||
| pip install --upgrade pip wheel setuptools | |||
There was a problem hiding this comment.
ok the reason this works took me a few days to workout, but basically celery prepends the current working directory to sys.path if it's not already present. This means the local source tree takes priority over installed modules so "import tests" works but "import dash" fails with a missing attribute on dash.dcc
When setuptools and wheel is installed pip will use "setup.py develop" which adds the current sys.path to site-packages/easy-install.pth which appends the current directory so the local source tree is available but installed modules take priority, this means "import tests" works and so does "import dash"
There was a problem hiding this comment.
adding setuptools here is just a workaround that causes pip to fallback to legacy editable project mode, I have a fix for modern editables here #2749
|
@alexcjohnson finally all the tests are passing! What do you think? |
|
@alexcjohnson should I rebase this off of dev? |
Yep! Then I'll give it a final review 🎉 |
graingert-coef
force-pushed
the
drop-3-6-support-3-12
branch
3 times, most recently
from
6ccf221
to
d9cdaaf
Compare
use py -3.12 -m to run pip call render.exe via Python312/Scripts dir
preconditions has been unmaintained for 9 years and calls the removed function inspect.getargspec
handle getfullargspec .keywords renamed to .varkw
pylint 3 will fail if all rules are disabled! It looks like all the rules got disabled in plotly@65a1d5c#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R11 so I added back as many rules that still pass. I'll restore the remaining rules in a followup PR
use passed in browser to distinguish browser type update smoke test to use .startswith()
previously exceptions were parsed line by line, however 3.11 introduced https://docs.python.org/3/whatsnew/3.11.html#whatsnew311-pep657 which means that exception line numbers and traceback skip offsets no longer line up. Rather than inspect the source code this change introduces an extra frame in `def _invoke_callback` that can be detected by walking the traceback and finding its code object.
graingert-coef
force-pushed
the
drop-3-6-support-3-12
branch
from
d9cdaaf
to
8d89156
Compare
|
@alexcjohnson ok I've rebased |
| @@ -15,7 +15,7 @@ | |||
| "private::format.black": "black dash_core_components_base/ tests/ setup.py", | |||
| "private::format.eslint": "eslint src --fix", | |||
| "private::format.prettier": "prettier --config .prettierrc --write src/**/*.js", | |||
| "private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python310') !== 'python36'){process.exit(1)} \" || black --check dash_core_components_base/ tests/ setup.py", | |||
| "private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python312') !== 'python38'){process.exit(1)} \" || black --check dash_core_components_base/ tests/ setup.py", | |||
There was a problem hiding this comment.
I suppose we can leave this as you have it for now, but way better would be to pick a version of black that supports all the same Python versions we do and always run it. The only reason we didn't do that from the start is that when we first introduced black we still supported Py2.7 and black was always Py3-only.
There was a problem hiding this comment.
I'll do this in a follow up PR
Co-authored-by: Alex Johnson <alex@plot.ly>
graingert-coef
force-pushed
the
drop-3-6-support-3-12
branch
from
d84abe2
to
87adad8
Compare
Fixes #2736
Contributor Checklist
optionals
CHANGELOG.md