Fix Dropdown Option Removal Regression #2816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2733.
The tests for the option removal only included non-searchable dropdowns.
The problem was that the guard clause would always be false for searchable dropdowns and the props on the component were never updated, even though the React component was showing the expected behavior. Removing the
!searchable
reintroduced another issue (#2099), so there needed to be a way to know if there was a current search happening or if the options had actually been changed.Instead of using
searchable
, create a state that is changed when the input is changed, indicating a search is being done. If there is a current search, don't update the options (and hence, don't render changes), else update the options.Contributor Checklist
search_value
.True
andFalse
.optionals
CHANGELOG.md