Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages with app.title and app.description #2826

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

AnnMarieW
Copy link
Collaborator

@AnnMarieW AnnMarieW commented Apr 2, 2024

Closes #2811

This PR allows the app.title and the (new) app.description to be used as defaults for the page title and page description

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • this GitHub #PR number updates the dash docs

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have some minor docstring suggestion for less repetition of the word supplied.

💃

dash/_pages.py Outdated Show resolved Hide resolved
dash/_pages.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -6,8 +6,9 @@ This project adheres to [Semantic Versioning](https://semver.org/).

## Added

- [#2826](https://github.com/plotly/dash/pull/2826) When using Pages, allows for `app.title` and (new) `app.description` to be used as defaults for the page title and description.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a reference to the fixed issue #2811 ?

AnnMarieW and others added 4 commits April 3, 2024 07:40
Co-authored-by: Philippe Duval <t4rk@outlook.com>
Co-authored-by: Philippe Duval <t4rk@outlook.com>
@T4rk1n T4rk1n merged commit 9379218 into plotly:dev Apr 3, 2024
3 checks passed
@AnnMarieW AnnMarieW deleted the pages-global-title-description branch April 3, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dash title design issues
2 participants