Fix clientside no outputs #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilykl
reviewed
May 23, 2024
| @@ -188,3 +196,39 @@ def on_click(_): | |||
| dash_duo.wait_for_style_to_equal( | |||
| "#output", "background-color", "rgba(255, 0, 0, 1)" | |||
| ) | |||
|
|
|||
|
|
|||
| def test_arb007_clientside_no_output(dash_duo): | |||
There was a problem hiding this comment.
@T4rk1n just a sanity check here since I'm not deeply familiar with the Dash tests -- this test fails without your fix, right?
There was a problem hiding this comment.
Yes it generates an error and the clientside function is not called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2866