Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove print statement from PreventUpdate handler. #548

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Remove print statement from PreventUpdate handler. #548

merged 2 commits into from
Jan 23, 2019

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Jan 20, 2019

Closes #516

@alexcjohnson
Copy link
Collaborator

Thanks @T4rk1n, this looks great! Just one question #516 (comment) to be discussed before letting this close #516.

@alexcjohnson
Copy link
Collaborator

Alright, I'm convinced - #516 (comment)
💃

alexcjohnson
alexcjohnson approved these changes Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry, gave a 💃 but it wasn't an official approving review...)

@T4rk1n T4rk1n force-pushed the remove-prevent-update-print branch from d2b476b to e1e8302 Compare January 23, 2019 16:49
@T4rk1n T4rk1n merged commit f15e085 into master Jan 23, 2019
@T4rk1n T4rk1n deleted the remove-prevent-update-print branch January 23, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@T4rk1n @alexcjohnson