use OrderedDict in byteify #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Feb 1, 2019
| @@ -25,8 +25,8 @@ | |||
| ) | |||
|
|
|||
| component$props <- filter_null(component$props) | |||
|
|
|||
| structure(component, class = c('dash_component', 'list')) | |||
There was a problem hiding this comment.
Not sure why this trailing whitespace wasn't caught by CI earlier... it's going to generate diffs in all the component packages that use it.
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
Fix Min/Max DatePickerRange date
AnnMarieW
pushed a commit
to AnnMarieW/dash
that referenced
this pull request
Jan 6, 2022
Fix Min/Max DatePickerRange date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick followup to #545 - We maintain order in py3, but in py2 where we run the objects through
byteifythey were reverting to regulardict. This keeps them asOrderedDict.Tested against
dcclocally.