Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote grid #894

Merged
merged 10 commits into from
Sep 3, 2019
Merged

Remote grid #894

merged 10 commits into from
Sep 3, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented Aug 29, 2019 •
edited
Loading

This closes #829

added a new argument --remote-url for the usage of selenium grid in the cloud, to test with a local host grid, users just need to add --remote

alexcjohnson
alexcjohnson approved these changes Aug 31, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 at some point it may be nice to include a test for this feature, but if that's going to be a major effort, I won't hold this up for it right now.

@byronz
Copy link
Contributor Author

byronz commented Aug 31, 2019

I will probably add few unit tests

@byronz byronz merged commit d1dc568 into dev Sep 3, 2019
@byronz byronz deleted the remote-grid branch September 3, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dash_duo does not set remote thus fails when get_webdriver is called
2 participants
@byronz @alexcjohnson