Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quart #976

Closed
wants to merge 4 commits into from
Closed

Quart #976

wants to merge 4 commits into from

Conversation

sjtrny
Copy link

@sjtrny sjtrny commented Oct 25, 2019

This PR migrates Dash from Flask to Quart. This change should not break existing Dash apps.

This is an effort to move the ship a few degrees closer to supporting some form of web socket update or callback. However I would expect support for this to be added in another PR.

TODO:

  • [] Replace minor dependencies on flask such as 'flask.helpers.get_root_path'
  • [] Swap references from flask to quart in code and docs
  • [] Update docs to discuss async callbacks including pitfalls such as calling sync code

@alexcjohnson
Copy link
Collaborator

@sjtrny thanks for the contribution. Looks like this went stale before getting to a reviewable state, so I'm going to close it. Apologies for leaving this with no response for so long.

We'd be amenable to discussing this kind of change, but it should probably go through an issue first so we can hash out an architecture that will satisfy everyone. Given that there are a lot of folks who plug Dash into existing Flask apps, we can't completely swap it out, but we may well be able to build in pluggable support for alternative servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants